[webkit-changes] [WebKit/WebKit] 271ed0: Change enums and unspecified enum classes to enum ...

Sammy Gill noreply at github.com
Wed May 24 17:36:29 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 271ed0f956ebf2bae8dc134368dd0d18883b5b20
      https://github.com/WebKit/WebKit/commit/271ed0f956ebf2bae8dc134368dd0d18883b5b20
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2023-05-24 (Wed, 24 May 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderFlexibleBox.cpp
    M Source/WebCore/rendering/RenderFlexibleBox.h

  Log Message:
  -----------
  Change enums and unspecified enum classes to enum class uint8_t in RenderFlexibleBox.
https://bugs.webkit.org/show_bug.cgi?id=257242
rdar://109745776

Reviewed by Aditya Keerthi.

We prefer to use enum classes whenever possible and RenderFlexibleBox
has an instance of an enum that can be modified. Also, all of the enums
in this class can fit into a uint8_t so we can also specify that.

* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::freezeInflexibleItems):
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
* Source/WebCore/rendering/RenderFlexibleBox.h:

Canonical link: https://commits.webkit.org/264494@main




More information about the webkit-changes mailing list