[webkit-changes] [WebKit/WebKit] 235db6: Align forbidden host and domain code points with s...

Alex Christensen noreply at github.com
Wed May 24 11:15:45 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 235db6f25f6187f42e36d21ca7b4559e20c14dd6
      https://github.com/WebKit/WebKit/commit/235db6f25f6187f42e36d21ca7b4559e20c14dd6
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-05-24 (Wed, 24 May 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_exclude=(file_javascript_mailto)-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/a-element_exclude=(file_javascript_mailto)-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_exclude=(file_javascript_mailto)-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_exclude=(file_javascript_mailto)-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-setters-stripping.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-setters-stripping.any.worker-expected.txt
    M Source/WTF/wtf/URLParser.cpp
    M Source/WTF/wtf/URLParser.h

  Log Message:
  -----------
  Align forbidden host and domain code points with spec and other browsers
https://bugs.webkit.org/show_bug.cgi?id=257213
rdar://109725285

Reviewed by Chris Dumez.

https://url.spec.whatwg.org/#forbidden-host-code-point and https://url.spec.whatwg.org/#forbidden-domain-code-point
are different sets of code points, the latter used when parsing special URL schemes and the former used when parsing
non-special URL schemes, though there is a large overlap.  Chrome and Firefox pass the tests that this PR makes WebKit pass.

* LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_exclude=(file_javascript_mailto)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/a-element_exclude=(file_javascript_mailto)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_exclude=(file_javascript_mailto)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_exclude=(file_javascript_mailto)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-setters-stripping.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-setters-stripping.any.worker-expected.txt:
* Source/WTF/wtf/URLParser.cpp:
(WTF::isC0Control):
(WTF::URLParser::isForbiddenHostCodePoint):
(WTF::URLParser::isForbiddenDomainCodePoint):
(WTF::URLParser::hasForbiddenHostCodePoint):
(WTF::URLParser::parseHostAndPort):
(WTF::isForbiddenHostCodePoint): Deleted.
* Source/WTF/wtf/URLParser.h:

Canonical link: https://commits.webkit.org/264482@main




More information about the webkit-changes mailing list