[webkit-changes] [WebKit/WebKit] 03f910: Add BufferedChangeEvent object

Jean-Yves Avenard noreply at github.com
Wed May 24 05:18:07 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 03f910f7ebd4cbeade20a0c7ebee6043979268ec
      https://github.com/WebKit/WebKit/commit/03f910f7ebd4cbeade20a0c7ebee6043979268ec
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2023-05-24 (Wed, 24 May 2023)

  Changed paths:
    M LayoutTests/media/media-source/media-managedmse-bufferedchange-expected.txt
    M LayoutTests/media/media-source/media-managedmse-bufferedchange.html
    A LayoutTests/media/media-source/mock-managedmse-bufferedchange-expected.txt
    A LayoutTests/media/media-source/mock-managedmse-bufferedchange.html
    M LayoutTests/media/utilities.js
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/DerivedSources-input.xcfilelist
    M Source/WebCore/DerivedSources-output.xcfilelist
    M Source/WebCore/DerivedSources.make
    A Source/WebCore/Modules/mediasource/BufferedChangeEvent.cpp
    A Source/WebCore/Modules/mediasource/BufferedChangeEvent.h
    A Source/WebCore/Modules/mediasource/BufferedChangeEvent.idl
    M Source/WebCore/Modules/mediasource/ManagedMediaSource.cpp
    M Source/WebCore/Modules/mediasource/ManagedMediaSource.h
    M Source/WebCore/Modules/mediasource/ManagedMediaSource.idl
    M Source/WebCore/Modules/mediasource/ManagedSourceBuffer.cpp
    M Source/WebCore/Modules/mediasource/ManagedSourceBuffer.h
    M Source/WebCore/Modules/mediasource/ManagedSourceBuffer.idl
    M Source/WebCore/Modules/mediasource/MediaSource.cpp
    M Source/WebCore/Modules/mediasource/MediaSource.h
    M Source/WebCore/Modules/mediasource/SourceBuffer.cpp
    M Source/WebCore/Modules/mediasource/SourceBuffer.h
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/bindings/js/WebCoreBuiltinNames.h
    M Source/WebCore/dom/EventNames.in
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/platform/graphics/PlatformTimeRanges.cpp
    M Source/WebCore/platform/graphics/PlatformTimeRanges.h

  Log Message:
  -----------
  Add BufferedChangeEvent object
https://bugs.webkit.org/show_bug.cgi?id=256985
rdar://109532732

Reviewed by Youenn Fablet.

Pass to `bufferedchange` a dictionary containing the range added and removed
from the last operation on the source buffer.

Fly-by: remove the need for code to be conditional on both ENABLE(MEDIA_SOURCE) and
ENABLE(MANAGED_MEDIA_SOURCE), assume that if the latter is true, then
so is the first, as doing otherwise would be totally nonsensical.

* LayoutTests/media/media-source/media-managedmse-bufferedchange-expected.txt:
* LayoutTests/media/media-source/media-managedmse-bufferedchange.html: Check that object received is of type BufferedChangeEvent
* LayoutTests/media/media-source/mock-managedmse-bufferedchange-expected.txt: Added.
* LayoutTests/media/media-source/mock-managedmse-bufferedchange.html: Added.
* LayoutTests/media/utilities.js:
(timeRangesToString):
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Modules/mediasource/BufferedChangeEvent.cpp: Copied from Source/WebCore/Modules/mediasource/ManagedSourceBuffer.cpp.
(WebCore::BufferedChangeEvent::BufferedChangeEvent):
(WebCore::BufferedChangeEvent::eventInterface const):
* Source/WebCore/Modules/mediasource/BufferedChangeEvent.h: Copied from Source/WebCore/Modules/mediasource/ManagedSourceBuffer.h.
* Source/WebCore/Modules/mediasource/BufferedChangeEvent.idl: Copied from Source/WebCore/Modules/mediasource/ManagedSourceBuffer.idl.
* Source/WebCore/Modules/mediasource/ManagedMediaSource.cpp:
* Source/WebCore/Modules/mediasource/ManagedMediaSource.h:
* Source/WebCore/Modules/mediasource/ManagedMediaSource.idl:
* Source/WebCore/Modules/mediasource/ManagedSourceBuffer.cpp:
* Source/WebCore/Modules/mediasource/ManagedSourceBuffer.h:
* Source/WebCore/Modules/mediasource/ManagedSourceBuffer.idl:
* Source/WebCore/Modules/mediasource/MediaSource.cpp:
* Source/WebCore/Modules/mediasource/MediaSource.h:
* Source/WebCore/Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::buffered):
(WebCore::SourceBuffer::sourceBufferPrivateBufferedChanged):
* Source/WebCore/Modules/mediasource/SourceBuffer.h:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
* Source/WebCore/dom/EventNames.in:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setBufferingPolicy): Change to be conditional on MANAGED_MEDIA_SOURCE
(WebCore::HTMLMediaElement::purgeBufferedDataIfPossible): same as above
* Source/WebCore/platform/graphics/PlatformTimeRanges.cpp:
(WebCore::PlatformTimeRanges::operator+=): Add alias to `unionWith` method for naming consistency.
(WebCore::PlatformTimeRanges::operator-=): Add operator to process calculation of range removal.
* Source/WebCore/platform/graphics/PlatformTimeRanges.h:

Canonical link: https://commits.webkit.org/264472@main




More information about the webkit-changes mailing list