[webkit-changes] [WebKit/WebKit] 3d5b4d: [WGSL] Only vertex input structs should have attri...

Tadeu Zagallo noreply at github.com
Wed May 24 04:27:27 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3d5b4df8a91410ca9a2245ecdb5567acbe5801c1
      https://github.com/WebKit/WebKit/commit/3d5b4df8a91410ca9a2245ecdb5567acbe5801c1
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-05-24 (Wed, 24 May 2023)

  Changed paths:
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp

  Log Message:
  -----------
  [WGSL] Only vertex input structs should have attribute annotations
https://bugs.webkit.org/show_bug.cgi?id=257218
rdar://109731268

Reviewed by Myles C. Maxfield.

We're currently annotating fields of user-defined structs with `[[attribute(x)]]`,
which is incorrect and causes compilation failures since packed types can't have
attribute annotations.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):

Canonical link: https://commits.webkit.org/264469@main




More information about the webkit-changes mailing list