[webkit-changes] [WebKit/WebKit] 12c38e: [WebXR] Refactor WebXROpaqueFramebuffer::setupFram...

Dan Glastonbury noreply at github.com
Wed May 24 01:14:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 12c38eddb8f19ee73b871eef5946b662a39a3ceb
      https://github.com/WebKit/WebKit/commit/12c38eddb8f19ee73b871eef5946b662a39a3ceb
  Author: Dan Glastonbury <djg at apple.com>
  Date:   2023-05-24 (Wed, 24 May 2023)

  Changed paths:
    M LayoutTests/platform/wpe/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_framebuffer_draw.https-expected.txt
    M LayoutTests/platform/wpe/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_opaque_framebuffer.https-expected.txt
    M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp
    M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.h
    M Source/WebCore/platform/graphics/GraphicsContextGL.h

  Log Message:
  -----------
  [WebXR] Refactor WebXROpaqueFramebuffer::setupFramebuffer
https://bugs.webkit.org/show_bug.cgi?id=257117
rdar://problem/109647523

Reviewed by Dean Jackson.

Reduce the complicated nesting of if/else statement by extracting common parts
into helper functions.

No features changed.

* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_framebuffer_draw.https-expected.txt:
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_opaque_framebuffer.https-expected.txt:
* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer):
(WebCore::WebXROpaqueFramebuffer::allocateRenderbufferStorage):
(WebCore::WebXROpaqueFramebuffer::allocateColorStorage):
(WebCore::WebXROpaqueFramebuffer::allocateDepthStencilStorage):
(WebCore::WebXROpaqueFramebuffer::bindColor):
(WebCore::WebXROpaqueFramebuffer::bindDepthStencil):
* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.h:
* Source/WebCore/platform/graphics/GraphicsContextGL.h:

Canonical link: https://commits.webkit.org/264466@main




More information about the webkit-changes mailing list