[webkit-changes] [WebKit/WebKit] f7494e: Improve error message for invalid selector

cybai (Haku) noreply at github.com
Wed May 24 00:28:17 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f7494e5433b34ac8860ce8773d75f5546b0cf164
      https://github.com/WebKit/WebKit/commit/f7494e5433b34ac8860ce8773d75f5546b0cf164
  Author: Cheng-You Bai <cyb.ai.815 at gmail.com>
  Date:   2023-05-24 (Wed, 24 May 2023)

  Changed paths:
    M LayoutTests/fast/css/css3-nth-tokens-script-expected.txt
    M LayoutTests/fast/css/parsing-css-attribute-case-insensitive-value-3-expected.txt
    M LayoutTests/fast/css/parsing-css-nth-child-of-3-expected.txt
    M LayoutTests/fast/css/parsing-css-nth-last-child-of-3-expected.txt
    M LayoutTests/fast/css/pseudo-class-internal-expected.txt
    M LayoutTests/fast/dom/SelectorAPI/dumpNodeList-almost-strict-expected.txt
    M LayoutTests/fast/dom/SelectorAPI/dumpNodeList-expected.txt
    M LayoutTests/fast/dom/SelectorAPI/not-supported-namespace-in-selector-expected.txt
    M LayoutTests/fast/selectors/closest-general-expected.txt
    M LayoutTests/fast/selectors/invalid-functional-pseudo-class-expected.txt
    M LayoutTests/fast/selectors/lang-empty-expected.txt
    M LayoutTests/fast/selectors/lang-extended-filtering-expected.txt
    M LayoutTests/fast/selectors/lang-extended-filtering-with-string-arguments-expected.txt
    M LayoutTests/fast/selectors/lang-invalid-expected.txt
    M LayoutTests/fast/selectors/lang-multiple-expected.txt
    M LayoutTests/fast/selectors/querySelector-pseudo-element-inside-functional-pseudo-class-not-expected.txt
    M LayoutTests/fast/shadow-dom/direct-focus-pseudo-does-not-match-in-author-stylesheet-expected.txt
    M LayoutTests/fast/text/text-combine-crash-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/highlight-pseudos-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/tree-abiding-pseudo-elements-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-context-parsing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/slotted-parsing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/selectors/attribute-selectors/attribute-case/semantics-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/selectors/attribute-selectors/attribute-case/syntax-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/selectors/webkit-pseudo-element-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/custom-elements/state.tentative/state-pseudo-class-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/custom-elements/state/tentative/state-pseudo-class-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-parts-structure.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/ordering/delay-load-event-1-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/ordering/delay-load-event-2-expected.txt
    M Source/WebCore/dom/Document.cpp

  Log Message:
  -----------
  Improve error message for invalid selector
https://bugs.webkit.org/show_bug.cgi?id=240597

Reviewed by Tim Nguyen.

This patch improves the error message for invalid selectors
(e.g. `Element.matches`, `document.querySelector` and so on).

* LayoutTests/fast/css/css3-nth-tokens-script-expected.txt:
* LayoutTests/fast/css/parsing-css-attribute-case-insensitive-value-3-expected.txt:
* LayoutTests/fast/css/parsing-css-nth-child-of-3-expected.txt:
* LayoutTests/fast/css/parsing-css-nth-last-child-of-3-expected.txt:
* LayoutTests/fast/css/pseudo-class-internal-expected.txt:
* LayoutTests/fast/dom/SelectorAPI/dumpNodeList-almost-strict-expected.txt:
* LayoutTests/fast/dom/SelectorAPI/dumpNodeList-expected.txt:
* LayoutTests/fast/dom/SelectorAPI/not-supported-namespace-in-selector-expected.txt:
* LayoutTests/fast/selectors/closest-general-expected.txt:
* LayoutTests/fast/selectors/invalid-functional-pseudo-class-expected.txt:
* LayoutTests/fast/selectors/lang-empty-expected.txt:
* LayoutTests/fast/selectors/lang-extended-filtering-expected.txt:
* LayoutTests/fast/selectors/lang-extended-filtering-with-string-arguments-expected.txt:
* LayoutTests/fast/selectors/lang-invalid-expected.txt:
* LayoutTests/fast/selectors/lang-multiple-expected.txt:
* LayoutTests/fast/selectors/querySelector-pseudo-element-inside-functional-pseudo-class-not-expected.txt:
* LayoutTests/fast/shadow-dom/direct-focus-pseudo-does-not-match-in-author-stylesheet-expected.txt:
* LayoutTests/fast/text/text-combine-crash-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/highlight-pseudos-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/tree-abiding-pseudo-elements-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-context-parsing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/slotted-parsing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/attribute-selectors/attribute-case/semantics-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/attribute-selectors/attribute-case/syntax-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/webkit-pseudo-element-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/state.tentative/state-pseudo-class-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/state/tentative/state-pseudo-class-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-parts-structure.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/ordering/delay-load-event-1-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/ordering/delay-load-event-2-expected.txt:
* Source/WebCore/dom/Document.cpp:

Canonical link: https://commits.webkit.org/264463@main




More information about the webkit-changes mailing list