[webkit-changes] [WebKit/WebKit] 8b8e72: HTMLOptionElement text setter should not have non-...

Ahmad Saleem noreply at github.com
Tue May 23 14:58:50 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b8e722170c26f24cf420b896cedcbcb979c6a86
      https://github.com/WebKit/WebKit/commit/8b8e722170c26f24cf420b896cedcbcb979c6a86
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-05-23 (Tue, 23 May 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-option-element/option-text-setter-expected.txt
    M Source/WebCore/html/HTMLOptionElement.cpp

  Log Message:
  -----------
  HTMLOptionElement text setter should not have non-conforming observable behavior

https://bugs.webkit.org/show_bug.cgi?id=257172

Reviewed by Aditya Keerthi.

This patch aligns WebKit with Web-Spec [1] and Blink / Chromium.

Merge: https://chromium-review.googlesource.com/c/chromium/src/+/721610

This patch removes non-conforming observable behavior to match the spec regarding using
textContent when setting internally as below:
"The text attribute's setter must string replace all with the given value within this element."

[1] https://html.spec.whatwg.org/#dom-option-text

* Source/WebCore/html/HTMLOptionElement.cpp:
(HTMLOptionElement::setText): As above
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-option-element/option-text-setter-expected.txt: Rebaselined

Canonical link: https://commits.webkit.org/264442@main




More information about the webkit-changes mailing list