[webkit-changes] [WebKit/WebKit] 229381: REGRESSION (264301 at main): _timeLabelsDisplayOnScru...

Tim Horton noreply at github.com
Tue May 23 13:05:01 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 229381d535516ea27068ee5d16faf05dcf383e3f
      https://github.com/WebKit/WebKit/commit/229381d535516ea27068ee5d16faf05dcf383e3f
  Author: Tim Horton <thorton at apple.com>
  Date:   2023-05-23 (Tue, 23 May 2023)

  Changed paths:
    M Source/WebCore/Modules/modern-media-controls/controls/time-control.js

  Log Message:
  -----------
  REGRESSION (264301 at main): _timeLabelsDisplayOnScrubberSide layout is broken (slider is shifted right)
https://bugs.webkit.org/show_bug.cgi?id=257216
rdar://109728864

Reviewed by Dean Jackson.

* Source/WebCore/Modules/modern-media-controls/controls/time-control.js:
(TimeControl.prototype._performIdealLayout):
264301 at main accidentally entangled some _timeLabelsDisplayOnScrubberSide logic
in its revert, causing the slider's leading offset to take the labels into account
even when they're displayed above the slider. Un-revert this part.

Canonical link: https://commits.webkit.org/264435@main




More information about the webkit-changes mailing list