[webkit-changes] [WebKit/WebKit] 9c6ff2: AX: WebAccessibilityObjectWrapperBase and WKAccess...

Tyler Wilcock noreply at github.com
Tue May 23 11:11:38 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9c6ff227993df1aff4587bcab0eb89838c9f3fab
      https://github.com/WebKit/WebKit/commit/9c6ff227993df1aff4587bcab0eb89838c9f3fab
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-05-23 (Tue, 23 May 2023)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityObjectInterface.h
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm
    M Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.h
    M Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm

  Log Message:
  -----------
  AX: WebAccessibilityObjectWrapperBase and WKAccessibilityWebPageObjectBase should hold WeakPtrs to their associated backing objects
https://bugs.webkit.org/show_bug.cgi?id=257071
rdar://109586801

Reviewed by Andres Gonzalez.

Continue the transition to ubiquitous smart pointer member usage per
https://github.com/WebKit/WebKit/wiki/Smart-Pointer-Usage-Guidelines.

* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper axBackingObject]):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase attachIsolatedObject:]):
(-[WebAccessibilityObjectWrapperBase hasIsolatedObject]):
(-[WebAccessibilityObjectWrapperBase axBackingObject]):

Canonical link: https://commits.webkit.org/264429@main




More information about the webkit-changes mailing list