[webkit-changes] [WebKit/WebKit] 2b3323: AVVideoCaptureSource intrinsicSize should be set a...

youennf noreply at github.com
Tue May 23 09:51:58 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2b3323161f9a2ea81cf3bad4691ee76bb166f5da
      https://github.com/WebKit/WebKit/commit/2b3323161f9a2ea81cf3bad4691ee76bb166f5da
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-05-23 (Tue, 23 May 2023)

  Changed paths:
    M Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
    M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm

  Log Message:
  -----------
  AVVideoCaptureSource intrinsicSize should be set at initialisation time
https://bugs.webkit.org/show_bug.cgi?id=257112
rdar://109283915

Reviewed by Eric Carlson.

The source intrinsicSize is used to compute the final video frame size in case constraints are setting only the width or only the height.
Make sure to set the intrisic size whenever the preset is set, which happens when the source gets created, at applying constraints time.
This ensures the intrinsic size is not zero when computing the video size after resizing.

* Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::computeResizedVideoFrameSize):
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::setFrameRateAndZoomWithPreset):

Canonical link: https://commits.webkit.org/264422@main




More information about the webkit-changes mailing list