[webkit-changes] [WebKit/WebKit] fb9630: ServiceWorker downloads fail when chunks are sent ...

youennf noreply at github.com
Tue May 23 02:29:53 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fb9630a9c9fc9d67def1d952fca7ba825a7c82ac
      https://github.com/WebKit/WebKit/commit/fb9630a9c9fc9d67def1d952fca7ba825a7c82ac
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-05-23 (Tue, 23 May 2023)

  Changed paths:
    M Source/WebCore/fileapi/URLKeepingBlobAlive.cpp
    M Source/WebCore/fileapi/URLKeepingBlobAlive.h

  Log Message:
  -----------
  ServiceWorker downloads fail when chunks are sent via postMessage
https://bugs.webkit.org/show_bug.cgi?id=256698
rdar://problem/109561888

Reviewed by Chris Dumez.

When isolatedCopying() && a URLKeepingBlobAlive, we would register the blob URL handle for the new URLKeepingBlobAlive,
but the moved URLKeepingBlobAlive would no longer unregister itself if its url is empty.
To prevent this, we remove the isolatedCopy() && version.
We could make URLKeepingBlobAlive to a move only type in a follow-up.

* Source/WebCore/fileapi/URLKeepingBlobAlive.cpp:
(WebCore::URLKeepingBlobAlive::isolatedCopy const):
(WebCore::URLKeepingBlobAlive::isolatedCopy): Deleted.
* Source/WebCore/fileapi/URLKeepingBlobAlive.h:

Canonical link: https://commits.webkit.org/264412@main




More information about the webkit-changes mailing list