[webkit-changes] [WebKit/WebKit] 4da294: [WGSL] EntryPointRewriter can't assume that return...

Tadeu Zagallo noreply at github.com
Tue May 23 00:13:22 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4da294485bf141234315e66fb945e026f0b9c79b
      https://github.com/WebKit/WebKit/commit/4da294485bf141234315e66fb945e026f0b9c79b
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-05-23 (Tue, 23 May 2023)

  Changed paths:
    M Source/WebGPU/WGSL/EntryPointRewriter.cpp

  Log Message:
  -----------
  [WGSL] EntryPointRewriter can't assume that return type is NamedTypeName
https://bugs.webkit.org/show_bug.cgi?id=257139
rdar://109668418

Reviewed by Dan Glastonbury.

In 264316 at main I introduced an incorrect assertion in `EntryPointRewriter::checkReturnType`.
We can't assert that the return type is a `NamedTypeName` (i.e. an identifier that refers
to a type). Instead, we return early if the return type is of a different kind.

* Source/WebGPU/WGSL/EntryPointRewriter.cpp:
(WGSL::EntryPointRewriter::checkReturnType):

Canonical link: https://commits.webkit.org/264408@main




More information about the webkit-changes mailing list