[webkit-changes] [WebKit/WebKit] c45236: [macOS] WebProcess names in Activity Monitor canno...

Chris Dumez noreply at github.com
Mon May 22 21:22:40 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c452365a271afb1e06bbce644c0da0948188783a
      https://github.com/WebKit/WebKit/commit/c452365a271afb1e06bbce644c0da0948188783a
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-05-22 (Mon, 22 May 2023)

  Changed paths:
    M Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm

  Log Message:
  -----------
  [macOS] WebProcess names in Activity Monitor cannot include non-Latin1 characters
https://bugs.webkit.org/show_bug.cgi?id=257179
rdar://109691473

Reviewed by Alex Christensen.

We are sending the application name as UTF-8 over XPC like so:
```
xpc_dictionary_set_string(bootstrapMessage.get(), "ui-process-name", [[[NSProcessInfo processInfo] processName] UTF8String]);
```

But we were decoding it as Latin1 instead of UTF-8 on the recipient side. This
was the cause of the bug.

* Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceInitializerDelegate::getClientProcessName):

Canonical link: https://commits.webkit.org/264403@main




More information about the webkit-changes mailing list