[webkit-changes] [WebKit/WebKit] bb5a5f: Notifications API: default silent to platform conv...

Marcos Cáceres noreply at github.com
Mon May 22 20:12:38 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb5a5fbce2e993ee60fbb3046b6e6c03693b49a0
      https://github.com/WebKit/WebKit/commit/bb5a5fbce2e993ee60fbb3046b6e6c03693b49a0
  Author: Marcos Caceres <marcosc at apple.com>
  Date:   2023-05-22 (Mon, 22 May 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/interfaces/notifications.idl
    M LayoutTests/imported/w3c/web-platform-tests/notifications/constructor-basic.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/notifications/constructor-basic.https.html
    M Source/WebCore/Modules/notifications/Notification.h
    M Source/WebCore/Modules/notifications/Notification.idl
    M Source/WebCore/Modules/notifications/NotificationOptions.idl
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm

  Log Message:
  -----------
  Notifications API: default silent to platform convention
https://bugs.webkit.org/show_bug.cgi?id=256828
rdar://109390045

Reviewed by Brady Eidson.

Makes the silent member on the NotificationOption dictionary default to null.
This is then reflected by the silent attribute of the Notification interface.

Spec change:
https://github.com/whatwg/notifications/pull/194

* LayoutTests/imported/w3c/web-platform-tests/interfaces/notifications.idl:
* LayoutTests/imported/w3c/web-platform-tests/notifications/constructor-basic.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/notifications/constructor-basic.https.html:
* Source/WebCore/Modules/notifications/Notification.h:
* Source/WebCore/Modules/notifications/Notification.idl:
* Source/WebCore/Modules/notifications/NotificationOptions.idl:

Canonical link: https://commits.webkit.org/264397@main




More information about the webkit-changes mailing list