[webkit-changes] [WebKit/WebKit] 348235: [import-w3c-tests] Make --clean-dest-dir work with...

Sam Sneddon noreply at github.com
Mon May 22 16:10:34 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 348235605fd930951b703860d93c3af15066998f
      https://github.com/WebKit/WebKit/commit/348235605fd930951b703860d93c3af15066998f
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2023-05-22 (Mon, 22 May 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/w3c/test_importer.py
    M Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

  Log Message:
  -----------
  [import-w3c-tests] Make --clean-dest-dir work with partial imports
https://bugs.webkit.org/show_bug.cgi?id=256751

Reviewed by Jonathan Bedard.

We need to do this slightly more lazily, and not just blanket clean
the entire destination directory.

Fix updating resource-files.json to write the file even if we aren't
importing new support files, as might be true of a partial import.

And finally fix removing items from tests-options.json to match
against the correct path, and avoid mutating the object we're
iterating over (which raises an RuntimeError).

* Tools/Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.__init__):
(TestImporter.do_import):
(TestImporter.import_tests):
(TestImporter.remove_slow_from_w3c_tests_options):
* Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:

Canonical link: https://commits.webkit.org/264384@main




More information about the webkit-changes mailing list