[webkit-changes] [WebKit/WebKit] 028635: Move the save icon SVG to mask-image

Gerald Squelart noreply at github.com
Mon May 22 14:00:51 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 02863595fea348b8af80a9b2e2168cb9c50836a8
      https://github.com/WebKit/WebKit/commit/02863595fea348b8af80a9b2e2168cb9c50836a8
  Author: Gerald Squelart <g_squelart at apple.com>
  Date:   2023-05-22 (Mon, 22 May 2023)

  Changed paths:
    M LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
    M LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
    M Source/WebCore/html/shadow/attachmentElementShadow.css

  Log Message:
  -----------
  Move the save icon SVG to mask-image
https://bugs.webkit.org/show_bug.cgi?id=256777
rdar://108621346

Reviewed by Tim Nguyen.

This makes it possible to use a semantic color as background, which will be correctly updated when the system light/dark mode changes.
And resize the icon, and use the bold version, to be closer to the specs.

Also unset the save button background-color inherited from the standard button CSS, which was having an impact on other colors.

* LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
* LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
* Source/WebCore/html/shadow/attachmentElementShadow.css:
(button#attachment-save-button):
(div#attachment-save-icon):

Canonical link: https://commits.webkit.org/264374@main




More information about the webkit-changes mailing list