[webkit-changes] [WebKit/WebKit] 576fb6: Take legend element into account in propagateRepai...

Rob Buis noreply at github.com
Mon May 22 12:49:51 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 576fb607ea63b0a91732c80950c4170dc34ac639
      https://github.com/WebKit/WebKit/commit/576fb607ea63b0a91732c80950c4170dc34ac639
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-05-22 (Mon, 22 May 2023)

  Changed paths:
    A LayoutTests/fast/multicol/legend-in-column-outline-auto-crash-expected.txt
    A LayoutTests/fast/multicol/legend-in-column-outline-auto-crash.html
    M Source/WebCore/rendering/RenderObject.cpp

  Log Message:
  -----------
  Take legend element into account in propagateRepaintToParentWithOutlineAutoIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=251381
rdar://104813886

Reviewed by Alan Baradlay.

In change r259412 logic was introduced for spanner placeholders and a check was done
to see if the previous sibling renderer is a column set. However legends are kept out of
column flows and thus may also have a column set as previous sibling, in this case we
don't want to enter the spanner placeholder logic.

* LayoutTests/fast/multicol/legend-in-column-outline-auto-crash-expected.txt: Added.
* LayoutTests/fast/multicol/legend-in-column-outline-auto-crash.html: Added.
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::propagateRepaintToParentWithOutlineAutoIfNeeded const):

Originally-landed-as: 260286.11 at webkit-2023.2-embargoed (e7b0459eaad2). rdar://104813886
Canonical link: https://commits.webkit.org/264350@main




More information about the webkit-changes mailing list