[webkit-changes] [WebKit/WebKit] c57f44: Deprecate isSpaceOrNewline

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c57f446617deaacdaa5d5435b909afd1d3fe596b
      https://github.com/WebKit/WebKit/commit/c57f446617deaacdaa5d5435b909afd1d3fe596b
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-05-22 (Mon, 22 May 2023)

  Changed paths:
    M Source/JavaScriptCore/runtime/ExceptionHelpers.cpp
    M Source/WTF/wtf/JSONValues.cpp
    M Source/WTF/wtf/text/StringImpl.cpp
    M Source/WTF/wtf/text/StringImpl.h
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
    M Source/WebCore/editing/Editor.cpp
    M Source/WebCore/editing/FrameSelection.cpp
    M Source/WebCore/editing/TextIterator.cpp
    M Source/WebCore/editing/TypingCommand.cpp
    M Source/WebCore/editing/VisibleSelection.cpp
    M Source/WebCore/html/TypeAhead.cpp
    M Source/WebCore/inspector/InspectorStyleSheet.cpp
    M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
    M Source/WebCore/page/LoggedInStatus.cpp
    M Source/WebCore/page/TextIndicator.cpp
    M Source/WebCore/page/ios/FrameIOS.mm
    M Source/WebCore/platform/Length.cpp
    M Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp
    M Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp
    M Source/WebCore/rendering/LegacyInlineFlowBox.cpp
    M Source/WebCore/rendering/LegacyLineLayout.cpp
    M Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp
    M Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp
    M Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm
    M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
    M Source/WebKitLegacy/mac/WebView/WebFrame.mm
    M Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm

  Log Message:
  -----------
  Deprecate isSpaceOrNewline
https://bugs.webkit.org/show_bug.cgi?id=257101
rdar://109621392

Reviewed by Darin Adler.

This renames isSpaceOrNewline to deprecatedIsSpaceOrNewline. And
similarly renames its inverse to deprecatedIsNotSpaceOrNewline.

This is because it looks like Unicode White_Space, but misses U+0085
and U+00A0 in the Latin1 scenario. Some callers account for the latter,
but never the former. And many callers don't even realize. Given that
isUnicodeWhitespace exists callers could migrate to that instead.

simplifyWhiteSpace and stripWhiteSpace that use this underneath will be
dealt with in bug 257084.

* Source/JavaScriptCore/runtime/ExceptionHelpers.cpp:
(JSC::invalidParameterInSourceAppender):
(JSC::invalidParameterInstanceofSourceAppender):
* Source/WTF/wtf/JSONValues.cpp:
(WTF::JSONImpl::Value::parseJSON):
* Source/WTF/wtf/text/StringImpl.cpp:
(WTF::StringImpl::stripWhiteSpace):
(WTF::StringImpl::simplifyWhiteSpace):
* Source/WTF/wtf/text/StringImpl.h:
(WTF::deprecatedIsSpaceOrNewline):
(WTF::isUnicodeWhitespace):
(WTF::deprecatedIsNotSpaceOrNewline):
(WTF::isSpaceOrNewline): Deleted.
(WTF::isNotSpaceOrNewline): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::stringForRange const):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
* Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::editorUIUpdateTimerFired):
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::FrameSelection::selectionAtWordStart const):
(WebCore::FrameSelection::wordSelectionContainingCaretSelection):
(WebCore::FrameSelection::selectionAtSentenceStart const):
* Source/WebCore/editing/TextIterator.cpp:
(WebCore::WordAwareIterator::advance):
* Source/WebCore/editing/TypingCommand.cpp:
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::markMisspellingsAfterTyping):
* Source/WebCore/editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::appendTrailingWhitespace):
* Source/WebCore/html/TypeAhead.cpp:
(WebCore::stripLeadingWhiteSpace):
* Source/WebCore/inspector/InspectorStyleSheet.cpp:
(WebCore::StyleSheetHandler::observeProperty):
(WebCore::StyleSheetHandler::observeComment):
* Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setAttributesAsText):
* Source/WebCore/page/LoggedInStatus.cpp:
(WebCore::LoggedInStatus::create):
* Source/WebCore/page/TextIndicator.cpp:
(WebCore::containsOnlyWhiteSpaceText):
* Source/WebCore/page/ios/FrameIOS.mm:
(WebCore::LocalFrame::wordsInCurrentParagraph const):
* Source/WebCore/platform/Length.cpp:
(WebCore::parseLength):
* Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp:
(WebCore::ResourceResponse::setStatusLine):
* Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::sanitizeFilename):
* Source/WebCore/rendering/LegacyInlineFlowBox.cpp:
(WebCore::LegacyInlineFlowBox::placeBoxRangeInInlineDirection):
* Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::LegacyLineLayout::computeInlineDirectionPositionsForSegment):
* Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::updateFromElement):
* Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp:
(WebCore::shouldSkipForFirstLetter):
* Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm:
(WebKit::makeTextRecognitionResult):
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::dictionaryPopupInfoForRange):
* Source/WebKitLegacy/mac/WebView/WebFrame.mm:
(-[WebFrame spaceFollowsWordInRange:]):
* Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm:
(+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):

Canonical link: https://commits.webkit.org/264344@main