[webkit-changes] [WebKit/WebKit] e76387: Fix break with MODERN_MEDIA_CONTROLS disabled afte...

ykimot noreply at github.com
Mon May 22 11:31:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e76387590957743e738a129d76106cf7fbd0f279
      https://github.com/WebKit/WebKit/commit/e76387590957743e738a129d76106cf7fbd0f279
  Author: Yousuke Kimoto <yousuke.kimoto at sony.com>
  Date:   2023-05-22 (Mon, 22 May 2023)

  Changed paths:
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.h
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl

  Log Message:
  -----------
  Fix break with MODERN_MEDIA_CONTROLS disabled after 264293 at main
https://bugs.webkit.org/show_bug.cgi?id=257114

Reviewed by Eric Carlson and Jer Noble.

`Since MediaControlsHost::sourceType()` is implemented in a
`MODERN_MEDIA_CONTROLS` macro block, the API and related things
should be managed with the macro condition.

* Source/WebCore/Modules/mediacontrols/MediaControlsHost.h: Expanded the `MODERN_MEDIA_CONTROLS` block to include `sourceType()` and related definitions.
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl: Added a `MODERN_MEDIA_CONTROLS` condition for sourceType

Canonical link: https://commits.webkit.org/264335@main




More information about the webkit-changes mailing list