[webkit-changes] [WebKit/WebKit] 8730f0: Move Page::renderingUpdateCompleted call to outsid...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8730f010fcbddd092d2602b3e4c1d61482adf6d4
      https://github.com/WebKit/WebKit/commit/8730f010fcbddd092d2602b3e4c1d61482adf6d4
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-05-22 (Mon, 22 May 2023)

  Changed paths:
    M Source/WebCore/page/Page.cpp

  Log Message:
  -----------
  Move Page::renderingUpdateCompleted call to outside loop in Page::finalizeRenderingUpdate
https://bugs.webkit.org/show_bug.cgi?id=257127
rdar://109664043

Reviewed by Tim Horton.

This does not change behavior with site isolation off because a page will only ever have
one root frame, which is always the main frame.  A root frame is a local frame that does
not have a local parent, which means its layer is a root drawing layer in this process
that will be composited in the UI process.

This change is needed as a step towards drawing multiple iframes in the same process,
in which case a Page would have multiple root frames.  It only needs to call renderingUpdateCompleted
once and if it doesn't then assertions and crashes happen.

This change is also needed to fix some crashes from https://github.com/WebKit/WebKit/pull/14025
but this change is completely unrelated so I'm doing it in a separate PR.

* Source/WebCore/page/Page.cpp:
(WebCore::Page::finalizeRenderingUpdate):
(WebCore::Page::finalizeRenderingUpdateForRootFrame):

Canonical link: https://commits.webkit.org/264330@main