[webkit-changes] [WebKit/WebKit] 49647f: [WGSL] Don't modify the user-defined vertex output...

Tadeu Zagallo noreply at github.com
Mon May 22 00:17:58 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 49647f66ed78c1542903200be12d1e213e7bbaab
      https://github.com/WebKit/WebKit/commit/49647f66ed78c1542903200be12d1e213e7bbaab
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-05-22 (Mon, 22 May 2023)

  Changed paths:
    M Source/WebGPU/WGSL/EntryPointRewriter.cpp
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
    M Source/WebGPU/WGSL/WGSLShaderModule.h

  Log Message:
  -----------
  [WGSL] Don't modify the user-defined vertex output struct
https://bugs.webkit.org/show_bug.cgi?id=257032
rdar://109565231

Reviewed by Myles C. Maxfield.

The user-defined struct can be used for other purposes, and it's not safe to modify it.

* Source/WebGPU/WGSL/EntryPointRewriter.cpp:
(WGSL::EntryPointRewriter::checkReturnType):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/WGSLShaderModule.h:
(WGSL::ShaderModule::replace):
(WGSL::ShaderModule::std::enable_if_t<sizeof):

Canonical link: https://commits.webkit.org/264316@main




More information about the webkit-changes mailing list