[webkit-changes] [WebKit/WebKit] 88af6d: [Cocoa] Add nextChildIdentifier() to VideoFullscre...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 88af6d51488ae4f6c0d62420e8f1e3c7d839fbcd
      https://github.com/WebKit/WebKit/commit/88af6d51488ae4f6c0d62420e8f1e3c7d839fbcd
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-05-21 (Sun, 21 May 2023)

  Changed paths:
    M Source/WebCore/platform/cocoa/VideoFullscreenModel.h
    M Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.h
    M Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm
    M Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm
    M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h
    M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm

  Log Message:
  -----------
  [Cocoa] Add nextChildIdentifier() to VideoFullscreenModel
https://bugs.webkit.org/show_bug.cgi?id=257067
rdar://109590097

Reviewed by Eric Carlson.

Multiple WebAVPlayerLayers can exist simultaneously, and disambiguating their logs when they coexist
can be difficult. Use LoggerHelper's concept of a "child identifier", and expose that child
identifier through VideoFullscreenModel. Each WebAVPlayerLayer will get a unique but related
identifier.

* Source/WebCore/platform/cocoa/VideoFullscreenModel.h:
(WebCore::VideoFullscreenModel::nextChildIdentifier const):
* Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.h:
* Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm:
(WebCore::VideoFullscreenModelVideoElement::nextChildIdentifier const):
* Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm:
(-[WebAVPlayerLayer setFullscreenModel:]):
(-[WebAVPlayerLayer videoRect]):
* Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
* Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenModelContext::nextChildIdentifier const):

Canonical link: https://commits.webkit.org/264309@main