[webkit-changes] [WebKit/WebKit] 0ee37c: Media Stats should show the media element's source

Jer Noble noreply at github.com
Sat May 20 09:52:52 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0ee37c4333af683443d1934d4cbb137bfcc7cb26
      https://github.com/WebKit/WebKit/commit/0ee37c4333af683443d1934d4cbb137bfcc7cb26
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-05-20 (Sat, 20 May 2023)

  Changed paths:
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.h
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl
    M Source/WebCore/Modules/modern-media-controls/media/media-controller.js
    M Source/WebCore/bindings/scripts/CodeGenerator.pm
    M Source/WebCore/en.lproj/modern-media-controls-localized-strings.js
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/html/HTMLMediaElement.h
    M Source/WebCore/platform/graphics/MediaPlayerEnums.h
    M Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp
    M Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  -----------
  Media Stats should show the media element's source
https://bugs.webkit.org/show_bug.cgi?id=256657
rdar://109219273

Reviewed by Eric Carlson.

Media Stats currently shows a lot of great information about the codecs and properties of the
media element's video and audio tracks. Also useful would be information about the element itself,
such as whether it's current source was a file, stream, media source, etc.

Add a new attribute to MediaControlsHost which vends this information up to the media controls. Add
support for detecting whether the AVURLAsset is backed by a HLS stream to MediaplayerPrivateAVFoundationObjC.

* Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::sourceType const):
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.h:
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl:
* Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype.setShowingStats):
* Source/WebCore/bindings/scripts/CodeGenerator.pm:
(WK_ucfirst):
* Source/WebCore/en.lproj/modern-media-controls-localized-strings.js:
* Source/WebCore/platform/graphics/MediaPlayerEnums.h:
* Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::movieLoadType const):
* Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::isHLS const):
* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus const):
(WebCore::assetMetadataKeyNames):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/264293@main




More information about the webkit-changes mailing list