[webkit-changes] [WebKit/WebKit] f20cec: Cherry-pick 264244 at main (a84036c6d1d6). https://bu...

[Carlos Alberto Lopez Perez]

  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: f20cec83d13b9dc4c3cbab33bc43118f04c6590d
      https://github.com/WebKit/WebKit/commit/f20cec83d13b9dc4c3cbab33bc43118f04c6590d
  Author: Carlos Alberto Lopez Perez <clopez at igalia.com>
  Date:   2023-05-20 (Sat, 20 May 2023)

  Changed paths:
    M Source/cmake/BubblewrapSandboxChecks.cmake

  Log Message:
  -----------
  Cherry-pick 264244 at main (a84036c6d1d6). https://bugs.webkit.org/show_bug.cgi?id=256032

    [WPE][GTK][CMake] The path to bwrap and xdg-dbus-proxy should not be auto-detected when cross-compiling
    https://bugs.webkit.org/show_bug.cgi?id=256679

    Reviewed by Adrian Perez de Castro.

    When enabling -DENABLE_BUBBLEWRAP_SANDBOX=ON is needed to define to the build
    the paths (full-paths) to the bwrap and xdg-dbus-proxy binaries.

    The current CMake code is auto-detecting those paths by calling the CMake
    function find_program(): so it is defining the paths to those programs with
    the values from the host system.

    But when cross-compiling that is wrong because the target binaries end with the
    values for the paths from the host system which don't necessary have to match
    the values from the target system.

    I can't see how it will be possible to auto-detect the value that this programs
    will have in the target system from the host system, so the only sane way of
    dealing with this seems to be to give an error at configure time and ask for
    those paths to be defined manually.

    This patch changes the code to only try to auto-detect those binaries when no
    cross-compiling.

    Also update the default build parameters for the cross-building of targets
    with cross-toolchain-helper to define the right paths that those targets will
    have at run-time.

    * Source/cmake/BubblewrapSandboxChecks.cmake:
    * Tools/yocto/targets.conf:

    Canonical link: https://commits.webkit.org/264244@main