[webkit-changes] [WebKit/WebKit] e17c21: Allow empty WPT variants from comments

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e17c2153ab908a5821a2b72ee9fe7856b98aac12
      https://github.com/WebKit/WebKit/commit/e17c2153ab908a5821a2b72ee9fe7856b98aac12
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2023-05-20 (Sat, 20 May 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-1000-reason.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-1000-reason.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-1000-verify-code.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-1000-verify-code.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-1000.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-1000.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-1005-verify-code.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-1005-verify-code.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-1005.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-1005.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-2999-reason.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-2999-reason.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-3000-reason.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-3000-reason.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-3000-verify-code.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-3000-verify-code.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-4999-reason.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-4999-reason.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-Reason-124Bytes.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-Reason-124Bytes.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-delayed.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-delayed.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-onlyReason.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-onlyReason.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-readyState-Closed.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-readyState-Closed.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-readyState-Closing.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-readyState-Closing.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-reason-unpaired-surrogates.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-reason-unpaired-surrogates.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-server-initiated-close.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-server-initiated-close.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-undefined.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Close-undefined.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-asciiSep-protocol-string.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-asciiSep-protocol-string.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-blocked-port.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-blocked-port.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-extensions-empty.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-extensions-empty.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-nonAscii-protocol-string.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-nonAscii-protocol-string.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-protocol-with-space.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-protocol-with-space.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-protocols-repeated-case-insensitive.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-protocols-repeated-case-insensitive.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-protocols-repeated.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-protocols-repeated.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-url-with-space.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-url-with-space.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-valid-url-array-protocols.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-valid-url-array-protocols.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-valid-url-binaryType-blob.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-valid-url-binaryType-blob.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-valid-url-protocol-empty.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-valid-url-protocol-empty.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-valid-url-protocol-setCorrectly.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-valid-url-protocol-setCorrectly.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-valid-url-protocol-string.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-valid-url-protocol-string.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-valid-url-protocol.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-valid-url-protocol.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-valid-url.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Create-valid-url.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-0byte-data.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-0byte-data.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-65K-data.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-before-open.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-before-open.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-65K-arraybuffer.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-65K-arraybuffer.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybuffer.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybuffer.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybufferview-float32.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybufferview-float32.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybufferview-float64.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybufferview-float64.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybufferview-int16-offset.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybufferview-int16-offset.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybufferview-int32.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybufferview-int32.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybufferview-int8.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybufferview-int8.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybufferview-uint16-offset-length.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybufferview-uint16-offset-length.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybufferview-uint32-offset.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybufferview-uint32-offset.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybufferview-uint8-offset-length.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybufferview-uint8-offset-length.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybufferview-uint8-offset.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-arraybufferview-uint8-offset.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-blob.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-binary-blob.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-data.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-data.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-null.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-null.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-paired-surrogates.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-paired-surrogates.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-unicode-data.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-unpaired-surrogates.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/Send-unpaired-surrogates.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.sharedworker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/close-invalid.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/close-invalid.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/constructor.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/constructor.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/eventhandlers.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/websockets/eventhandlers.any.worker-expected.txt
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy.py
    M Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy_unittest.py

  Log Message:
  -----------
  Allow empty WPT variants from comments
https://bugs.webkit.org/show_bug.cgi?id=256581

Reviewed by Chris Dumez.

This makes us match tools/manifest/sourcefile.py with what we allow as
valid variants, and increases our test coverage here.

* Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy.py:
(LayoutTestFinder._expand_variants):
(LayoutTestFinder._is_valid_variant):
* Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy_unittest.py:
(LayoutTestFinderTests.test_find_template_variants_meta):
(LayoutTestFinderTests.test_find_template_variants): Deleted.

Canonical link: https://commits.webkit.org/264289@main