[webkit-changes] [WebKit/WebKit] 7a80df: Regression(263830 at main) Frequent Jetsams on macOS ...

Chris Dumez noreply at github.com
Fri May 19 23:03:40 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7a80dfacdb26f49d6dea6ded444f7b1ffce578b5
      https://github.com/WebKit/WebKit/commit/7a80dfacdb26f49d6dea6ded444f7b1ffce578b5
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-05-19 (Fri, 19 May 2023)

  Changed paths:
    M Source/WebKit/Scripts/update-info-plist-for-runningboard.sh

  Log Message:
  -----------
  Regression(263830 at main) Frequent Jetsams on macOS 13.3+
https://bugs.webkit.org/show_bug.cgi?id=257077
rdar://109517882

Reviewed by Wenson Hsieh.

In 263830 at main, I updated the script to compare TARGET_MAC_OS_X_VERSION_MAJOR
to 130300 instead of 130000, since we only use RunningBoard on macOS 13.3+.
However, TARGET_MAC_OS_X_VERSION_MAJOR only contains the "major" version,
meaning that it is 130000 on all macOS 13.x versions. As a result, the check
now fails on macOS 13.x and we don't mark our processes as managed by
RunningBoard, even though our code uses RunningBoard on macOS 13.3.

To address the issue, we now rely on the MACOSX_DEPLOYMENT_TARGET variable
instead, which contains both the major and minor version (formatted like
"13.3").

* Source/WebKit/Scripts/update-info-plist-for-runningboard.sh:

Canonical link: https://commits.webkit.org/264286@main




More information about the webkit-changes mailing list