[webkit-changes] [WebKit/WebKit] 2fefca: [WGSL] Only pack and pad user-defined structs

Tadeu Zagallo noreply at github.com
Fri May 19 15:43:59 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2fefca2ae91fb881dcfbd8fda7e72f4092dc425c
      https://github.com/WebKit/WebKit/commit/2fefca2ae91fb881dcfbd8fda7e72f4092dc425c
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-05-19 (Fri, 19 May 2023)

  Changed paths:
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp

  Log Message:
  -----------
  [WGSL] Only pack and pad user-defined structs
https://bugs.webkit.org/show_bug.cgi?id=257033
rdar://109565469

Reviewed by Myles C. Maxfield.

We can't use the packed types (packed_uint3, etc) in the vertex function's output.
Also a minor fix after 264231 at main, while we don't want *most* structs to have
built-in attributes in its fields, we do need them for the vertex output struct.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):

Canonical link: https://commits.webkit.org/264277@main




More information about the webkit-changes mailing list