[webkit-changes] [WebKit/WebKit] cb345f: AX: Move [WebAccessibilityObjectWrapper windowElem...

AndresGonzalezApple noreply at github.com
Fri May 19 10:50:05 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cb345f2eccf03e362b521fb1ddd449ab19ea2a94
      https://github.com/WebKit/WebKit/commit/cb345f2eccf03e362b521fb1ddd449ab19ea2a94
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2023-05-19 (Fri, 19 May 2023)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityObjectInterface.h
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

  Log Message:
  -----------
  AX: Move [WebAccessibilityObjectWrapper windowElement:] off the main thread.
https://bugs.webkit.org/show_bug.cgi?id=256896
<rdar://problem/109462537>

Reviewed by Tyler Wilcock.

This method was hitting the main thread to get the platformWidget of the LocalFrameView. But the LocalFrameView must have an AccessibilityScrollView object associated with it, and its corresponding AXIsolatedObject is caching the PlatformWidget. Thus this patch avoids hitting the main thread by using this direct path on the AX thread instead of having to go through the LocalFrameView.
Added the AXCoreObject::axScrollView method to return the closest AX object ancestor to an object that represents a ScrollView.

* Source/WebCore/accessibility/AccessibilityObjectInterface.h:
(WebCore::AXCoreObject::axScrollView const):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper windowElement:]):

Canonical link: https://commits.webkit.org/264266@main




More information about the webkit-changes mailing list