[webkit-changes] [WebKit/WebKit] 0aad38: [Cairo] Unnecessary overrides `GraphicsContext::dr...

Vitaly Dyachkov noreply at github.com
Fri May 19 08:16:59 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0aad38b2c52686d3a70ca03b845d24eebf594c70
      https://github.com/WebKit/WebKit/commit/0aad38b2c52686d3a70ca03b845d24eebf594c70
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2023-05-19 (Fri, 19 May 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/cairo/FontCairo.cpp
    M Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
    M Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.h

  Log Message:
  -----------
  [Cairo] Unnecessary overrides `GraphicsContext::drawGlyphs()` and `GraphicsContext::drawDecomposedGlyphs()`
https://bugs.webkit.org/show_bug.cgi?id=257019

Reviewed by Carlos Garcia Campos.

Default `GraphicsContext::drawGlyphs()` simply calls
`FontCascade::drawGlyphs()` but `GraphicsContextCairo::drawGlyphs()`
duplicates the logic of `FontCascade::drawGlyphs()`.

`GraphicsContextCairo::drawDecomposedGlyphs()` is virtually the same as
`GraphicsContext::drawDecomposedGlyphs()`.

* Source/WebCore/platform/graphics/cairo/FontCairo.cpp:
(WebCore::FontCascade::drawGlyphs):
* Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContextCairo::drawGlyphs): Deleted.
(WebCore::GraphicsContextCairo::drawDecomposedGlyphs): Deleted.
* Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.h:

Canonical link: https://commits.webkit.org/264258@main




More information about the webkit-changes mailing list