[webkit-changes] [WebKit/WebKit] 3ebf7a: Make sure a controllerchange event gets fired on c...

Chris Dumez noreply at github.com
Fri May 19 08:05:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3ebf7a86bf38b50ccb2982ef6040051ec356a75a
      https://github.com/WebKit/WebKit/commit/3ebf7a86bf38b50ccb2982ef6040051ec356a75a
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-05-19 (Fri, 19 May 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/clear-site-data/storage.https-expected.txt
    M Source/WebCore/workers/service/SWClientConnection.cpp
    M Source/WebCore/workers/service/SWClientConnection.h
    M Source/WebCore/workers/service/server/SWServer.h
    M Source/WebCore/workers/service/server/SWServerRegistration.cpp
    M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
    M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.h
    M Source/WebKit/WebProcess/Storage/WebSWClientConnection.messages.in

  Log Message:
  -----------
  Make sure a controllerchange event gets fired on clients when a service worker gets deleted
https://bugs.webkit.org/show_bug.cgi?id=256982

Reviewed by Youenn Fablet.

Make sure a controllerchange event gets fired on clients when a service worker gets deleted.
This matches Firefox and Chrome's behavior.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/clear-site-data/storage.https-expected.txt:
* Source/WebCore/workers/service/SWClientConnection.cpp:
(WebCore::updateController):
(WebCore::SWClientConnection::notifyClientsOfControllerChange):
* Source/WebCore/workers/service/SWClientConnection.h:
* Source/WebCore/workers/service/server/SWServer.h:
* Source/WebCore/workers/service/server/SWServerRegistration.cpp:
(WebCore::SWServerRegistration::notifyClientsOfControllerChange):
(WebCore::SWServerRegistration::clear):
* Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::notifyClientsOfControllerChange):
* Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.h:
* Source/WebKit/WebProcess/Storage/WebSWClientConnection.messages.in:

Canonical link: https://commits.webkit.org/264255@main




More information about the webkit-changes mailing list