[webkit-changes] [WebKit/WebKit] 8b48b8: textareas logical height with overflow auto should...

Alan Baradlay noreply at github.com
Fri May 19 07:53:54 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b48b8b9e8b826979b747f9c11166b3f03c850c3
      https://github.com/WebKit/WebKit/commit/8b48b8b9e8b826979b747f9c11166b3f03c850c3
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-05-19 (Fri, 19 May 2023)

  Changed paths:
    M LayoutTests/platform/ios-wk2/fast/forms/basic-textareas-quirks-expected.txt
    M LayoutTests/platform/ios/fast/forms/basic-textareas-expected.txt
    M LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt
    M LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.txt
    M Source/WebCore/rendering/RenderTextControl.cpp

  Log Message:
  -----------
  textareas logical height with overflow auto shouldn't add scrollbar-thickness
https://bugs.webkit.org/show_bug.cgi?id=256811
<rdar://problem/109384976>

Reviewed by Simon Fraser.

"This change fixes the scrollbar thickness incorrectly being included in the textarea when overflow is hidden or clipped."
Merged from Blink: https://chromium.googlesource.com/chromium/src/+/18481ffa332076e58fd9adbbea2062c2ba087dfb

* Source/WebCore/rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight const):

* LayoutTests/platform/ios-wk2/fast/forms/basic-textareas-quirks-expected.txt:
* LayoutTests/platform/ios/fast/forms/basic-textareas-expected.txt:
* LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt: interop progression.
* LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.txt: interop progression.
* Source/WebCore/rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight const):

Canonical link: https://commits.webkit.org/264251@main




More information about the webkit-changes mailing list