[webkit-changes] [WebKit/WebKit] a84036: [WPE][GTK][CMake] The path to bwrap and xdg-dbus-p...

[Carlos Alberto Lopez Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a84036c6d1d66d723f217a4c29eee76f2039a353
      https://github.com/WebKit/WebKit/commit/a84036c6d1d66d723f217a4c29eee76f2039a353
  Author: Carlos Alberto Lopez Perez <clopez at igalia.com>
  Date:   2023-05-19 (Fri, 19 May 2023)

  Changed paths:
    M Source/cmake/BubblewrapSandboxChecks.cmake
    M Tools/yocto/targets.conf

  Log Message:
  -----------
  [WPE][GTK][CMake] The path to bwrap and xdg-dbus-proxy should not be auto-detected when cross-compiling
https://bugs.webkit.org/show_bug.cgi?id=256679

Reviewed by Adrian Perez de Castro.

When enabling -DENABLE_BUBBLEWRAP_SANDBOX=ON is needed to define to the build
the paths (full-paths) to the bwrap and xdg-dbus-proxy binaries.

The current CMake code is auto-detecting those paths by calling the CMake
function find_program(): so it is defining the paths to those programs with
the values from the host system.

But when cross-compiling that is wrong because the target binaries end with the
values for the paths from the host system which don't necessary have to match
the values from the target system.

I can't see how it will be possible to auto-detect the value that this programs
will have in the target system from the host system, so the only sane way of
dealing with this seems to be to give an error at configure time and ask for
those paths to be defined manually.

This patch changes the code to only try to auto-detect those binaries when no
cross-compiling.

Also update the default build parameters for the cross-building of targets
with cross-toolchain-helper to define the right paths that those targets will
have at run-time.

* Source/cmake/BubblewrapSandboxChecks.cmake:
* Tools/yocto/targets.conf:

Canonical link: https://commits.webkit.org/264244@main