[webkit-changes] [WebKit/WebKit] d6f9f3: [WGSL] Struct members shouldn't have built-in attr...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d6f9f3ee61b8accacdc7790d72fcb03af4e84811
      https://github.com/WebKit/WebKit/commit/d6f9f3ee61b8accacdc7790d72fcb03af4e84811
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-05-18 (Thu, 18 May 2023)

  Changed paths:
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp

  Log Message:
  -----------
  [WGSL] Struct members shouldn't have built-in attributes
https://bugs.webkit.org/show_bug.cgi?id=256967
rdar://109515831

Reviewed by Mike Wyrzykowski and Dan Glastonbury.

It's invalid for MSL code to have built-in attributes in struct members, and at
this point of the compilation these inputs were already hoisted into parameters
of the entry point function, so we should just skip the serialization of built-in
attributes if we are serializing a struct.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):

Canonical link: https://commits.webkit.org/264231@main