[webkit-changes] [WebKit/WebKit] dc59cc: [IFC][Iterators] InlineIterator::TextBox::selectio...

Alan Baradlay noreply at github.com
Thu May 18 16:37:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc59cc20b177597eb34d3af78837456c2dcee931
      https://github.com/WebKit/WebKit/commit/dc59cc20b177597eb34d3af78837456c2dcee931
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-05-18 (Thu, 18 May 2023)

  Changed paths:
    M Source/WebCore/layout/integration/inline/InlineIteratorTextBox.cpp
    M Source/WebCore/layout/integration/inline/InlineIteratorTextBox.h
    M Source/WebCore/rendering/RenderText.cpp

  Log Message:
  -----------
  [IFC][Iterators] InlineIterator::TextBox::selectionRect is a standalone helper function
https://bugs.webkit.org/show_bug.cgi?id=256974

Reviewed by Antti Koivisto.

Let's keep the iterator interface clean.

* Source/WebCore/layout/integration/inline/InlineIteratorTextBox.cpp:
(WebCore::InlineIterator::TextBox::selectionRect const): Deleted.
* Source/WebCore/layout/integration/inline/InlineIteratorTextBox.h:
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::selectionRectForTextBox):
(WebCore::RenderText::collectSelectionGeometries):
(WebCore::boundariesForTextBox):
(WebCore::ellipsisRectForTextBox):
(WebCore::collectAbsoluteQuads):
(WebCore::localQuadForTextBox):
(WebCore::RenderText::absoluteQuadsForRange const):
(WebCore::RenderText::collectSelectionGeometriesForLineBoxes):
(WebCore::boundariesForTextRun): Deleted.
(WebCore::ellipsisRectForTextRun): Deleted.
(WebCore::localQuadForTextRun): Deleted.

Canonical link: https://commits.webkit.org/264221@main




More information about the webkit-changes mailing list