[webkit-changes] [WebKit/WebKit] ab78a7: Avoid running WheelEventTestMonitor-related test-o...

Simon Fraser noreply at github.com
Thu May 18 12:13:05 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ab78a74247b81231d5b746c71e724db5fc8910c2
      https://github.com/WebKit/WebKit/commit/ab78a74247b81231d5b746c71e724db5fc8910c2
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-05-18 (Thu, 18 May 2023)

  Changed paths:
    M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp
    M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm

  Log Message:
  -----------
  Avoid running WheelEventTestMonitor-related test-only code when not testing
https://bugs.webkit.org/show_bug.cgi?id=256934
rdar://109488666

Reviewed by Wenson Hsieh.

RemoteScrollingTreeMac::deferWheelEventTestCompletionForReason() and RemoteScrollingTreeMac::removeWheelEventTestCompletionDeferralForReason()
would always trigger the hop to main thread, and IPC with the web process. We only need to do that when running layout tests
that use `eventSender.monitorWheelEvents()`, and the RemoteScrollingTree already has a bit for that, so use it.

* Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp:
(WebKit::RemoteScrollingTree::deferWheelEventTestCompletionForReason):
(WebKit::RemoteScrollingTree::removeWheelEventTestCompletionDeferralForReason):
* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm:
(WebKit::RemoteScrollingTreeMac::deferWheelEventTestCompletionForReason):
(WebKit::RemoteScrollingTreeMac::removeWheelEventTestCompletionDeferralForReason):

Canonical link: https://commits.webkit.org/264208@main




More information about the webkit-changes mailing list