[webkit-changes] [WebKit/WebKit] 62269b: [GStreamer] Audio sinks created by media players leak

Philippe Normand noreply at github.com
Thu May 18 00:52:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62269b67734dc36d28162694c6d266580c5605af
      https://github.com/WebKit/WebKit/commit/62269b67734dc36d28162694c6d266580c5605af
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-05-18 (Thu, 18 May 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h

  Log Message:
  -----------
  [GStreamer] Audio sinks created by media players leak
https://bugs.webkit.org/show_bug.cgi?id=256899

Reviewed by Xabier Rodriguez-Calvar.

Replace the leaky g_object_get() with a simple accessor to the m_audioSink member variable.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::audioSink const): Deleted.
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(WebCore::MediaPlayerPrivateGStreamer::audioSink const):

Canonical link: https://commits.webkit.org/264193@main




More information about the webkit-changes mailing list