[webkit-changes] [WebKit/WebKit] 8b1424: Add BBQ and OMG allow lists to JSC options

Commit Queue noreply at github.com
Wed May 17 17:12:23 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b1424b44716f59295d952310e1a5ac509640611
      https://github.com/WebKit/WebKit/commit/8b1424b44716f59295d952310e1a5ac509640611
  Author: David Degazio <d_degazio at apple.com>
  Date:   2023-05-17 (Wed, 17 May 2023)

  Changed paths:
    M Source/JavaScriptCore/runtime/OptionsList.h
    M Source/JavaScriptCore/tools/FunctionAllowlist.cpp
    M Source/JavaScriptCore/tools/FunctionAllowlist.h
    M Source/JavaScriptCore/wasm/WasmBBQPlan.cpp
    M Source/JavaScriptCore/wasm/WasmBBQPlan.h
    M Source/JavaScriptCore/wasm/WasmOMGPlan.cpp
    M Source/JavaScriptCore/wasm/WasmOMGPlan.h
    M Source/JavaScriptCore/wasm/WasmOperations.cpp
    M Source/JavaScriptCore/wasm/WasmSlowPaths.cpp

  Log Message:
  -----------
  Add BBQ and OMG allow lists to JSC options
https://bugs.webkit.org/show_bug.cgi?id=256914
rdar://109474140

Reviewed by Justin Michaud.

Adds --bbqAllowlist and --omgAllowlist options to the JSC command line.
Like existing allowlist options, these take either the single function
to allow compilation of, or a path to a file containing one allowed
function per line. Since WASM doesn't necessarily keep names in source,
and we don't currently employ the same function hashing technique we do
in JS, allowed functions are currently specified by function index.

* Source/JavaScriptCore/runtime/OptionsList.h:
* Source/JavaScriptCore/tools/FunctionAllowlist.cpp:
(JSC::FunctionAllowlist::FunctionAllowlist):
(JSC::FunctionAllowlist::shouldDumpWasmFunction const):
(JSC::FunctionAllowlist::containsWasmFunction const):
* Source/JavaScriptCore/tools/FunctionAllowlist.h:
* Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:
(JSC::Wasm::BBQPlan::ensureGlobalBBQAllowlist):
* Source/JavaScriptCore/wasm/WasmBBQPlan.h:
* Source/JavaScriptCore/wasm/WasmOMGPlan.cpp:
(JSC::Wasm::OMGPlan::ensureGlobalOMGAllowlist):
* Source/JavaScriptCore/wasm/WasmOMGPlan.h:
* Source/JavaScriptCore/wasm/WasmOperations.cpp:
(JSC::Wasm::shouldJIT):
* Source/JavaScriptCore/wasm/WasmSlowPaths.cpp:
(JSC::LLInt::shouldJIT):
(JSC::LLInt::jitCompileAndSetHeuristics):

Canonical link: https://commits.webkit.org/264184@main




More information about the webkit-changes mailing list