[webkit-changes] [WebKit/WebKit] 108369: JSC::Yarr::Flags in RegularExpression

Anne van Kesteren noreply at github.com
Tue May 16 22:23:47 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1083694fd4b7f1755a24f1b99b4eb01acbeec888
      https://github.com/WebKit/WebKit/commit/1083694fd4b7f1755a24f1b99b4eb01acbeec888
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-05-16 (Tue, 16 May 2023)

  Changed paths:
    M Source/JavaScriptCore/inspector/ContentSearchUtilities.cpp
    M Source/JavaScriptCore/yarr/RegularExpression.cpp
    M Source/JavaScriptCore/yarr/RegularExpression.h
    M Source/WebCore/html/BaseTextInputType.cpp
    M Source/WebCore/html/EmailInputType.cpp
    M Source/WebCore/inspector/InspectorStyleSheet.cpp
    M Source/WebCore/page/LocalFrame.cpp
    M Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm
    M Source/WebCore/platform/mac/StringUtilities.mm
    M Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm

  Log Message:
  -----------
  JSC::Yarr::Flags in RegularExpression
https://bugs.webkit.org/show_bug.cgi?id=255982
rdar://108836530

Reviewed by Ross Kirsling.

Replace the MultilineMode, TextCaseSensitivity, and UnicodeMode enums
with JSC::Yarr:Flags and add an assert that prevents using the other
flags mainly to ensure folks use them consciously.

Also remove the JSC::Yarr prefix when it's not needed.

* Source/JavaScriptCore/inspector/ContentSearchUtilities.cpp:
(Inspector::ContentSearchUtilities::createRegularExpressionForSearchString):
* Source/JavaScriptCore/yarr/RegularExpression.cpp:
(JSC::Yarr::RegularExpression::Private::compile):
* Source/JavaScriptCore/yarr/RegularExpression.h:
* Source/WebCore/html/BaseTextInputType.cpp:
(WebCore::BaseTextInputType::patternMismatch const):
* Source/WebCore/html/EmailInputType.cpp:
(WebCore::isValidEmailAddress):
* Source/WebCore/inspector/InspectorStyleSheet.cpp:
(WebCore::selectorsFromSource):
* Source/WebCore/page/LocalFrame.cpp:
(WebCore::createRegExpForLabels):
* Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:
(WebCore::CDMPrivateMediaSourceAVFObjC::parseKeySystem):
* Source/WebCore/platform/mac/StringUtilities.mm:
(WebCore::stringMatchesWildcardString):
* Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm:
(regExpForLabels):

Canonical link: https://commits.webkit.org/264136@main




More information about the webkit-changes mailing list