[webkit-changes] [WebKit/WebKit] e60a65: More explicit error messages for new URL(url, base...

Karl Dubost noreply at github.com
Tue May 16 16:21:58 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e60a65f91bc5b4ae4c6cd886c0a88b510dd8e103
      https://github.com/WebKit/WebKit/commit/e60a65f91bc5b4ae4c6cd886c0a88b510dd8e103
  Author: Karl Dubost <karlcow at apple.com>
  Date:   2023-05-16 (Tue, 16 May 2023)

  Changed paths:
    M LayoutTests/fast/dom/DOMURL/parsing-expected.txt
    M LayoutTests/fast/dom/DOMURL/url-constructor-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-values/urls/resolve-relative-to-base-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_exclude=(file_javascript_mailto)-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_exclude=(file_javascript_mailto)-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-referrer-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/workers/modules/shared-worker-import-referrer-expected.txt
    M Source/WebCore/html/DOMURL.cpp

  Log Message:
  -----------
  More explicit error messages for new URL(url, base) Constructor
https://bugs.webkit.org/show_bug.cgi?id=256692
rdar://109253920

Reviewed by Tim Nguyen.

This gives a more explicit message for `new URL()` instead of just
TypeError. It is also more readable in the console.

* LayoutTests/fast/dom/DOMURL/parsing-expected.txt:
* LayoutTests/fast/dom/DOMURL/url-constructor-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-values/urls/resolve-relative-to-base-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_exclude=(file_javascript_mailto)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_exclude=(file_javascript_mailto)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-referrer-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/modules/shared-worker-import-referrer-expected.txt:
* Source/WebCore/html/DOMURL.cpp:
(WebCore::DOMURL::create):
(WebCore::DOMURL::create):

Canonical link: https://commits.webkit.org/264129@main




More information about the webkit-changes mailing list