[webkit-changes] [WebKit/WebKit] 9e1f20: Change AllowedBaseline enum to enum class.

Sammy Gill noreply at github.com
Tue May 16 14:27:20 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9e1f206c762c490815fb1fd90f4116c9a030d9e9
      https://github.com/WebKit/WebKit/commit/9e1f206c762c490815fb1fd90f4116c9a030d9e9
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2023-05-16 (Tue, 16 May 2023)

  Changed paths:
    M Source/WebCore/rendering/BaselineAlignmentInlines.h
    M Source/WebCore/rendering/RenderGrid.cpp
    M Source/WebCore/rendering/RenderGrid.h

  Log Message:
  -----------
  Change AllowedBaseline enum to enum class.
https://bugs.webkit.org/show_bug.cgi?id=256794
rdar://109362850

Reviewed by Tim Nguyen.

It is preferable to use enum classes over standard enums and this is
another one that can be converted from an enum to an enum class.

* Source/WebCore/rendering/BaselineAlignmentInlines.h:
(): Deleted.
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::isBaselineAlignmentForChild const):
(WebCore::RenderGrid::getBaselineChild const):
* Source/WebCore/rendering/RenderGrid.h:

Canonical link: https://commits.webkit.org/264127@main




More information about the webkit-changes mailing list