[webkit-changes] [WebKit/WebKit] 4a8d69: Combine requestScrollPositionUpdate() and requestA...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4a8d697cd1a24177aa04af9a65ce24464d690f24
      https://github.com/WebKit/WebKit/commit/4a8d697cd1a24177aa04af9a65ce24464d690f24
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-05-16 (Tue, 16 May 2023)

  Changed paths:
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/page/LocalFrameView.h
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp
    M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h
    M Source/WebCore/page/scrolling/ScrollingCoordinator.h
    M Source/WebCore/platform/ScrollView.cpp
    M Source/WebCore/platform/ScrollableArea.cpp
    M Source/WebCore/platform/ScrollableArea.h
    M Source/WebCore/rendering/RenderLayerScrollableArea.cpp
    M Source/WebCore/rendering/RenderLayerScrollableArea.h

  Log Message:
  -----------
  Combine requestScrollPositionUpdate() and requestAnimatedScrollToPosition()
https://bugs.webkit.org/show_bug.cgi?id=256824
rdar://109386012

Reviewed by Alan Baradlay.

Combine `requestScrollPositionUpdate()` and `requestAnimatedScrollToPosition()` into a single
set of calls, with a `ScrollIsAnimated` argument, renaming `requestScrollPositionUpdate()` to
`requestScrollToPosition()`.

`AsyncScrollingCoordinator::requestScrollToPosition()` does an immediate update only if not animated.

`ScrollableArea::scrollToPositionWithAnimation()` has to pass a type of ScrollType::Programmatic
which is what the called function used to do.

`AsyncScrollingCoordinator::setMouseIsOverScrollbar()` is just moved.

* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::requestScrollToPosition):
(WebCore::LocalFrameView::requestScrollPositionUpdate): Deleted.
(WebCore::LocalFrameView::requestAnimatedScrollToPosition): Deleted.
* Source/WebCore/page/LocalFrameView.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
* Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::requestScrollToPosition):
(WebCore::AsyncScrollingCoordinator::stopAnimatedScroll):
(WebCore::AsyncScrollingCoordinator::setMouseIsOverScrollbar):
(WebCore::AsyncScrollingCoordinator::setMouseIsOverContentArea):
(WebCore::AsyncScrollingCoordinator::setMouseMovedInContentArea):
(WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate): Deleted.
(WebCore::AsyncScrollingCoordinator::requestAnimatedScrollToPosition): Deleted.
* Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h:
* Source/WebCore/page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::requestScrollToPosition):
(WebCore::ScrollingCoordinator::requestScrollPositionUpdate): Deleted.
(WebCore::ScrollingCoordinator::requestAnimatedScrollToPosition): Deleted.
* Source/WebCore/platform/ScrollView.cpp:
(WebCore::ScrollView::scrollTo):
(WebCore::ScrollView::setScrollPosition):
* Source/WebCore/platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scrollToPositionWithAnimation):
(WebCore::ScrollableArea::setScrollPositionFromAnimation):
* Source/WebCore/platform/ScrollableArea.h:
(WebCore::ScrollableArea::requestScrollToPosition):
(WebCore::ScrollableArea::requestScrollPositionUpdate): Deleted.
(WebCore::ScrollableArea::requestAnimatedScrollToPosition): Deleted.
* Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::requestScrollToPosition):
(WebCore::RenderLayerScrollableArea::scrollToOffset):
(WebCore::RenderLayerScrollableArea::requestScrollPositionUpdate): Deleted.
(WebCore::RenderLayerScrollableArea::requestAnimatedScrollToPosition): Deleted.
* Source/WebCore/rendering/RenderLayerScrollableArea.h:

Canonical link: https://commits.webkit.org/264119@main