[webkit-changes] [WebKit/WebKit] 1bb728: RemoteImageBufferProxy flush wait is unbounded

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1bb728e3b8bbac80ef6572e6d184ea5a95ce58da
      https://github.com/WebKit/WebKit/commit/1bb728e3b8bbac80ef6572e6d184ea5a95ce58da
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-05-15 (Mon, 15 May 2023)

  Changed paths:
    M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp

  Log Message:
  -----------
  RemoteImageBufferProxy flush wait is unbounded
https://bugs.webkit.org/show_bug.cgi?id=256779
rdar://problem/109344110

Reviewed by Matt Woodrow.

The commit 263993 at main would change the flush wait from being a IPC
message wait to being a IPC::Semaphore wait. The semaphore wait will not
stop if the signaller, GPUP, has crashed. Also, it is never good to
have an unbounded wait.

Instead, wait with the standard remote rendering timeout value.
The wait location will be moved to RemoteImageBufferProxy in future
commits.

* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::addPendingFlush):

Canonical link: https://commits.webkit.org/264104@main