[webkit-changes] [WebKit/WebKit] 9ae5f9: Fix width of textarea with overflow hidden includi...

Luke Warlow noreply at github.com
Mon May 15 18:42:53 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9ae5f9cb52ff27fd13396e631c1ccf8d8603e2b6
      https://github.com/WebKit/WebKit/commit/9ae5f9cb52ff27fd13396e631c1ccf8d8603e2b6
  Author: Luke Warlow <luke at warlow.dev>
  Date:   2023-05-15 (Mon, 15 May 2023)

  Changed paths:
    M LayoutTests/platform/gtk/fast/forms/basic-textareas-expected.png
    M LayoutTests/platform/gtk/fast/forms/basic-textareas-expected.txt
    M LayoutTests/platform/gtk/fast/forms/basic-textareas-quirks-expected.png
    M LayoutTests/platform/gtk/fast/forms/basic-textareas-quirks-expected.txt
    M LayoutTests/platform/ios-wk2/fast/forms/basic-textareas-quirks-expected.txt
    M LayoutTests/platform/ios/fast/forms/basic-textareas-expected.txt
    M LayoutTests/platform/ios/fast/forms/basic-textareas-quirks-expected.txt
    M LayoutTests/platform/mac/fast/forms/basic-textareas-expected.png
    M LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt
    M LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.png
    M LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.txt
    M Source/WebCore/rendering/RenderTextControlMultiLine.cpp

  Log Message:
  -----------
  Fix width of textarea with overflow hidden including scrollbar thickness
https://bugs.webkit.org/show_bug.cgi?id=256697

Reviewed by Alan Baradlay.

This no longer includes the scrollbar thickness in the textarea width
when overflow is hidden or clip. This matches Firefox's behaviour.

* LayoutTests/platform/gtk/fast/forms/basic-textareas-expected.png:
* LayoutTests/platform/gtk/fast/forms/basic-textareas-expected.txt:
* LayoutTests/platform/gtk/fast/forms/basic-textareas-quirks-expected.png:
* LayoutTests/platform/gtk/fast/forms/basic-textareas-quirks-expected.txt:
* LayoutTests/platform/ios-wk2/fast/forms/basic-textareas-quirks-expected.txt:
* LayoutTests/platform/ios/fast/forms/basic-textareas-expected.txt:
* LayoutTests/platform/ios/fast/forms/basic-textareas-quirks-expected.txt:
* LayoutTests/platform/mac/fast/forms/basic-textareas-expected.png:
* LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt:
* LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.png:
* LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
* Source/WebCore/rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::preferredContentLogicalWidth const):

Canonical link: https://commits.webkit.org/264095@main




More information about the webkit-changes mailing list