[webkit-changes] [WebKit/WebKit] 8f64a0: (macOS) Several keyboard scrolling `fast/scrolling...

Richard Robinson noreply at github.com
Mon May 15 17:35:36 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8f64a049e50112312c4a0a317fdde1ea4e7dd1ce
      https://github.com/WebKit/WebKit/commit/8f64a049e50112312c4a0a317fdde1ea4e7dd1ce
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-05-15 (Mon, 15 May 2023)

  Changed paths:
    M LayoutTests/fast/scrolling/arrow-key-scroll-in-rtl-document-expected.txt
    M LayoutTests/fast/scrolling/arrow-key-scroll-in-rtl-document.html
    M LayoutTests/fast/scrolling/keyboard-scrolling-distance-downArrow.html
    M LayoutTests/fast/scrolling/mac/keyboard-scrolling-terminates.html
    M Source/WebCore/platform/ScrollingEffectsController.cpp
    M Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp

  Log Message:
  -----------
  (macOS) Several keyboard scrolling `fast/scrolling` layout tests are failing
https://bugs.webkit.org/show_bug.cgi?id=256351
rdar://108931777

Reviewed by Ryosuke Niwa.

Several layout tests have been starting to fail. Fix by:
1. Ensuring `ScrollAnimatorEnabled` is enabled
2. Fixing a typo to ensure the scroll deferrer works properly
3. Ensure a rendering update occurs between key down events and key up events

* LayoutTests/fast/scrolling/arrow-key-scroll-in-rtl-document.html:
* LayoutTests/fast/scrolling/keyboard-scrolling-distance-downArrow.html:
* LayoutTests/fast/scrolling/mac/keyboard-scrolling-terminates.html:
* Source/WebCore/platform/ScrollingEffectsController.cpp:
(WebCore::ScrollingEffectsController::scrollAnimationDidEnd):

Canonical link: https://commits.webkit.org/264093@main




More information about the webkit-changes mailing list