[webkit-changes] [WebKit/WebKit] 61a321: Fix the bug that @supports selector() fails for al...

joonghunpark noreply at github.com
Mon May 15 16:49:10 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 61a3212d56eac0d26cf3f7af8a4ece7d902e0bcf
      https://github.com/WebKit/WebKit/commit/61a3212d56eac0d26cf3f7af8a4ece7d902e0bcf
  Author: Joonghun Park <jh718.park at samsung.com>
  Date:   2023-05-15 (Mon, 15 May 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/css/parser/CSSSelectorParser.cpp

  Log Message:
  -----------
  Fix the bug that @supports selector() fails for all -webkit- pseudo elements.
https://bugs.webkit.org/show_bug.cgi?id=241847

Reviewed by Tim Nguyen.

According to the spec, https://drafts.csswg.org/css-conditional-4/#support-definition-ext,
@supports selector() should fail only for *unknown* -webkit- pseudo elements,
not all -webkit- pseudo elements.

Because CSSSelector::parsePseudoElementType treats all -webkit- pseudo elements as valid
as described in https://drafts.csswg.org/selectors-4/#compat,
this patch uses WebCore::parsePseudoElementString to identify unknown -webkit- pseudo elements.

* LayoutTests/TestExpectations:
* Source/WebCore/css/parser/CSSSelectorParser.cpp:
(WebCore::CSSSelectorParser::containsUnknownWebKitPseudoElements):

Canonical link: https://commits.webkit.org/264090@main




More information about the webkit-changes mailing list