[webkit-changes] [WebKit/WebKit] af6778: AX: HTML menu element should map to role=list

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: af6778aa0405885a7638a1ef60e195cf050483a9
      https://github.com/WebKit/WebKit/commit/af6778aa0405885a7638a1ef60e195cf050483a9
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-05-15 (Mon, 15 May 2023)

  Changed paths:
    M LayoutTests/accessibility/display-contents-element-roles-expected.txt
    R LayoutTests/accessibility/mac/menu-type-toolbar-expected.txt
    R LayoutTests/accessibility/mac/menu-type-toolbar.html
    M LayoutTests/accessibility/roles-exposed.html
    M LayoutTests/platform/glib/accessibility/aria-visible-element-roles-expected.txt
    M LayoutTests/platform/glib/accessibility/display-contents-element-roles-expected.txt
    M LayoutTests/platform/ios/accessibility/display-contents-element-roles-expected.txt
    M LayoutTests/platform/mac-wk1/accessibility/aria-visible-element-roles-expected.txt
    M LayoutTests/platform/mac-wk1/accessibility/roles-exposed-expected.txt
    M LayoutTests/platform/mac-wk2/accessibility/aria-visible-element-roles-expected.txt
    M LayoutTests/platform/mac-wk2/accessibility/roles-exposed-expected.txt
    M LayoutTests/platform/wpe/accessibility/aria-visible-element-roles-expected.txt
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AccessibilityList.cpp
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp

  Log Message:
  -----------
  AX: HTML menu element should map to role=list
https://bugs.webkit.org/show_bug.cgi?id=201581
rdar://55145117

Reviewed by Tyler Wilcock.

As far as I can tell we only have a special code path remaining for
"type=touchbar", not "toolbar", thus removing that.

Otherwise this generally makes the menu element behave like an ul
element for accessibility purposes.

This builds on work in #3571 by SirriCelles.

* LayoutTests/accessibility/display-contents-element-roles-expected.txt:
* LayoutTests/accessibility/mac/menu-type-toolbar-expected.txt: Removed.
* LayoutTests/accessibility/mac/menu-type-toolbar.html: Removed.
* LayoutTests/accessibility/roles-exposed.html:
* LayoutTests/platform/glib/accessibility/aria-visible-element-roles-expected.txt:
* LayoutTests/platform/glib/accessibility/display-contents-element-roles-expected.txt:
* LayoutTests/platform/ios/accessibility/display-contents-element-roles-expected.txt:
* LayoutTests/platform/mac-wk1/accessibility/aria-visible-element-roles-expected.txt:
* LayoutTests/platform/mac-wk1/accessibility/roles-exposed-expected.txt:
* LayoutTests/platform/mac-wk2/accessibility/aria-visible-element-roles-expected.txt:
* LayoutTests/platform/mac-wk2/accessibility/roles-exposed-expected.txt:
* LayoutTests/platform/wpe/accessibility/aria-visible-element-roles-expected.txt:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::createObjectFromRenderer):
* Source/WebCore/accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::isUnorderedList const):
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole const):

Canonical link: https://commits.webkit.org/264077@main