[webkit-changes] [WebKit/WebKit] a9a42e: [WGSL] workgroup_size attribute shouldn't generate...

Tadeu Zagallo noreply at github.com
Mon May 15 08:07:43 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a9a42e39f7915c5be11ce0086fa0b42056b76939
      https://github.com/WebKit/WebKit/commit/a9a42e39f7915c5be11ce0086fa0b42056b76939
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-05-15 (Mon, 15 May 2023)

  Changed paths:
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp

  Log Message:
  -----------
  [WGSL] workgroup_size attribute shouldn't generate code
https://bugs.webkit.org/show_bug.cgi?id=256700
rdar://109261518

Reviewed by Mike Wyrzykowski and Dan Glastonbury.

The information from `@workgroup_size` is passed to the API, and after that we
shouldn't generate any code for it. Right now, it will run through the default
visitor, which will serialize its arguments adding spurious numbers to the output.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):

Canonical link: https://commits.webkit.org/264072@main




More information about the webkit-changes mailing list