[webkit-changes] [WebKit/WebKit] e4a261: REGRESSION(262138 at main): [GStreamer] Broke video r...

Philippe Normand noreply at github.com
Mon May 15 01:43:15 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e4a2619c7a4cedbe5fba2bd5ab5143c0e6a0617a
      https://github.com/WebKit/WebKit/commit/e4a2619c7a4cedbe5fba2bd5ab5143c0e6a0617a
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-05-15 (Mon, 15 May 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
    M Tools/Scripts/webkitpy/port/glib.py

  Log Message:
  -----------
  REGRESSION(262138 at main): [GStreamer] Broke video rendering when GL is disabled
https://bugs.webkit.org/show_bug.cgi?id=256757

Reviewed by Xabier Rodriguez-Calvar.

The sample received from the Cairo sink is not transfer-full, so we shouldn't adopt its reference.
Driving by, also allow passthrough of the WEBKIT_GST_DISABLE_GL_SINK environment variable in the
test harness.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createVideoSink):
* Tools/Scripts/webkitpy/port/glib.py:
(GLibPort.setup_environ_for_server):

Canonical link: https://commits.webkit.org/264064@main




More information about the webkit-changes mailing list