[webkit-changes] [WebKit/WebKit] 9fbeca: [JSC] Convert StrCat to MakeRope in constant-foldi...

Yusuke Suzuki noreply at github.com
Sun May 14 21:39:51 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9fbecab3d6ef2869c5736fc71a59fe5903ea04b7
      https://github.com/WebKit/WebKit/commit/9fbecab3d6ef2869c5736fc71a59fe5903ea04b7
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-05-14 (Sun, 14 May 2023)

  Changed paths:
    M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h
    M Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp

  Log Message:
  -----------
  [JSC] Convert StrCat to MakeRope in constant-folding phase
https://bugs.webkit.org/show_bug.cgi?id=256239
rdar://108819092

Reviewed by Justin Michaud.

Just convert StrCat to MakeRope if all input values are proven to be Strings.
MakeRope is faster than StrCat since it can fully inline allocation of JSRopeString.

* Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):

Canonical link: https://commits.webkit.org/264061@main




More information about the webkit-changes mailing list