[webkit-changes] [WebKit/WebKit] 9db465: Don't add empty rects during addFocusRingRects

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9db465cd1226e45cbce6dc0c9e058b9bb59ff918
      https://github.com/WebKit/WebKit/commit/9db465cd1226e45cbce6dc0c9e058b9bb59ff918
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-05-14 (Sun, 14 May 2023)

  Changed paths:
    A LayoutTests/fast/css/ignore-empty-focus-ring-rects-expected.html
    A LayoutTests/fast/css/ignore-empty-focus-ring-rects.html
    M Source/WebCore/rendering/RenderInline.cpp

  Log Message:
  -----------
  Don't add empty rects during addFocusRingRects

https://bugs.webkit.org/show_bug.cgi?id=249930
rdar://problem/103897005

Reviewed by Alan Baradlay.

Merge: https://chromium.googlesource.com/chromium/blink/+/2cf30f0fb85c90f6ae813264aa0d0dcc9a85ab58

We don't add empty rects during addFocusRingRects except during
generateLineBoxRects in RenderInline::addFocusRingRects.

Empty rects in focus ring rects causes small circle drawn around
the top-left corner of the empty rects on Mac.

Added AbsoluteRectsIgnoringEmptyRectsGeneratorContext for
addFocusRingRects to ignore empty line box rects.

* Source/WebCore/rendering/RenderInline.cpp:
(AbsoluteRectsIgnoringEmptyGeneratorContext): new class in namespace
(RenderInline::addFocusRingRects): Use 'AbsoluteRectsIgnoringEmptyGeneratorContext'
* LayoutTests/fast/css/ignore-empty-focus-ring-rects.html: Add Test Case
* LayoutTests/fast/css/ignore-empty-focus-ring-rects-expected.html: Add Test Case Expectation

Canonical link: https://commits.webkit.org/264058@main